Add Pliny::Helpers::ZuluTime to Serializers::Base #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @ransombriggs. The only thing missing that I notice is updating the generators so that new serializers will use this rather than @brandur Do you have comments on this? |
|
@gudmundur pushed up serializer template changes in 4a30e49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gudmundur this adds a
ZuluTimemodule to the pliny library that is mixed intoSerializers::Baseto provide azulu_timemethod to help serialize dates properly. One of the apps I am extracting this out of usesDateTimeinstances which do not have agetutcuntilactive_support/core_ext/numeric/timeis mixed in. Should I add a check to see iftimeresponds togetutcand throw a more helpful error if it is not defined?